[Series] Implementation #608
Conversation
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Updated UUID.
| cmp-ok( # begin: 7ae7a46a-d992-4c2a-9c15-a112d125ebad | ||
| series("1", 1), | ||
| "eqv", | ||
| $["1"], |
There was a problem hiding this comment.
Use the decontanerization operator before calling .raku if you want to omit the leading $s
https://docs.raku.org/language/operators#postcircumfix_%3C%3E
There was a problem hiding this comment.
Should all the .raku calls be prefixed with decontainerization ?
PS. The files are all over the place — so sorry — I'll fix that. That's the first and last time I try drag and drop on GitHub ! I was just trying to speed things up ! Sigh.
There was a problem hiding this comment.
It shouldn't be necessary for all of them. Usually the ones that could use decontainerization are contents of arrays.
There was a problem hiding this comment.
I put one in on the expected result %case<expected>.<>.raku, so now the generated tests read:
cmp-ok( # begin: 7ae7a46a-d992-4c2a-9c15-a112d125ebad
series("1", 1),
"eqv",
["1"],
"slices of one from one",
); # end: 7ae7a46a-d992-4c2a-9c15-a112d125ebad
|
The files are currently in the main |
…/.meta/solutions/Series.rakumod
…s/series.rakutest
…ries/.meta/template-data.yaml
…ercises/practice/series/Series.rakumod
[GitHub drag and drop] File missing from flattening with duplicate filename
|
I moved all the files misplaced by GitHub Drag & Drop. Thank you for your patience. |
| cmp-ok( # begin: 7ae7a46a-d992-4c2a-9c15-a112d125ebad | ||
| series("1", 1), | ||
| "eqv", | ||
| ["1"], |
There was a problem hiding this comment.
I'd personally prefer a list for the sake of consistency. I tend to choose lists over arrays if I have no intention of assigning/modifying the contents: https://github.com/exercism/raku/blob/main/exercises/practice/all-your-base/all-your-base.rakutest
There was a problem hiding this comment.
Agreed and completed.
|
I changed to a smartmatch to allow for greater equivalence as that feels more rakuish. What do you feel about putting |
|
Putting
|
Shall we dispense of it in the robot exercise then ? stub: |-
has Str:D $.name = '';
method reset-name {!!!} |
Agreement.